search

edannenberg / kubler

A generic, extendable build orchestrator.
BSD 2-Clause "Simplified" License
157 stars 40 forks source link

Patches in acct-user.eclass failing due to recent changes #218

Closed r7l closed 1 year ago

r7l commented 1 year ago

Seems like they've added some changes to acct-user.eclass again. This causes 0003-Revert-acct-user.eclass-Fixing-user-group-creation-w.patch to fail and stop Kubler from working. It seems as if some of the code you've patched has been removed completely.

r7l commented 1 year ago

I've tried to look into this for a bit and figure if there might be a way around this. But i am not really experienced with all the side effects of $ROOT. Looking into the most recent commits, they've changed quite a bit of code including dependencies and even dropped some functions. I would guess, patching eclass files back isn't going to work out well long term. Ebuilds will rely on current eclass files and that might cause more issues.

r7l commented 1 year ago

Maybe i am naive here but i've went through this with locally patching Kubler to not patch files in Portage and instead create a empty file at ${_EMERGE_ROOT}/etc/group if there is non, in order to get past the issue of not having the file. The build process successfully went through after that and i don't have any issues (yet) with a number of different images. Even rebuilding with prebuild packages does work.

I've compared the final images with ones created with a older state of Portage with Kubler patches. I don't see anything different in /etc/passwd or /etc/group files.

I've not yet ran into any issue with fowners or anything as outlined in 209.

r7l commented 1 year ago

Nevermind my last comment. I've tested more images and actually ran into multiple issues. And yes, fowners can hit issues as well.

edannenberg commented 1 year ago

I updated the patch for acct-user.eclass and added a new one for acct-group.eclass. If you are still running into problems after updating Kubler please manually delete any respective binary packages and try again.

r7l commented 1 year ago

Just wanted to say thank again. Your fix works perfektly. Did a rebuild of my entire stack and it went through as before.