search

edannenberg / maven-magento-plugin

A Maven plugin for Magento projects.
Apache License 2.0
7 stars 3 forks source link

Wrong magento example modul version #2

Closed mediarox closed 12 years ago

mediarox commented 12 years ago

If you create a new archetype (magento-sample-module-archetype) the plugin generates the following modul configuration file:

... <modules> <Namespace_Modulename> <version>1.0-SNAPSHOT</version> ... </Namespace_Modulename> </modules> ...

The version value "1.0-SNAPSHOT" is apparently the value you have entered on archetype generation process. Instead it must be correspond to the generated installscript name such as "mysql4-install-0.0.1.php". In that case "0.0.1".

edannenberg commented 12 years ago

How about the installscript reflecting the entered module version instead? Does make more sense to me.

Edit: I guess non-numeric versions like above would be problematic so gonna set the version in config.xml static for now.

edannenberg commented 12 years ago

Fixed with https://github.com/edannenberg/maven-magento-archetypes/commit/01521c79dec6c2664da3ac5084c89157facdd4b6