search

edasque / DynamoDBtoCSV

Dump DynamoDB data into a CSV file
Apache License 2.0
471 stars 152 forks source link

Limit not working #20

Closed msambol closed 7 years ago

msambol commented 7 years ago

Limit does not appear to be working.

It defaults to 1000 but several of my scans returned more than 1000.

@edasque

edasque commented 7 years ago

I no longer have access to an account with DynamoDB. Please submit a PR or give me access to one if you'd like me to take a look. Changes to the SDK over time are probably to blame for issues.

msambol commented 7 years ago

I'll check it out.

msambol commented 7 years ago

Ah, so it does actually work correctly, but because of the following code we essentially ignore the limit. Should I make a PR that removes the limit from the query?

https://github.com/edasque/DynamoDBtoCSV/blob/master/dynamoDBtoCSV.js#L43-L45

edasque commented 7 years ago

It's probably best you fork and maintain your own, I can point to yours being in active development.