search

edasque / DynamoDBtoCSV

Dump DynamoDB data into a CSV file
Apache License 2.0
471 stars 152 forks source link

Fix commander not parsing arguments #66

Closed ArFe closed 2 years ago

ArFe commented 3 years ago

Commander does not accept getting the options directly from program. Need to create options variable.

Added this line (after .parse(process.argv) ): const options = program.opts();

And replace program by options thereafter.

ArFe commented 3 years ago

good point. Any other?

On Mon, 29 Mar 2021 at 15:25, Erik Dasque @.***> wrote:

@.**** commented on this pull request.

In dynamoDBtoCSV.js https://github.com/edasque/DynamoDBtoCSV/pull/66#discussion_r603554519:

console.log("You must specify a table");

  • program.outputHelp();
  • options.outputHelp();

I don't think that's correct. options is doesn't have an outputHelp method. it's a program.OptionValue

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/edasque/DynamoDBtoCSV/pull/66#pullrequestreview-623572985, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCUFVK4PKJD2WOYN2VHK3LTGDH4LANCNFSM42AE5TDA .

rafaelribeirokuhn commented 3 years ago

It took some time for me to figure out what was going on and to fix this error. I was going to open a PR exactly like this one when I saw it already has been made. I wish this PR has been merged before :(

DollarAkshay commented 3 years ago

This should be merged into the main branch. I had the same issue and using the code in this branch worked

houmie commented 2 years ago

Why has this not been merged yet? This project is not functional without this.

UPDATE: This seems now out of date. Merging it locally fails with this error:

undefined:1
undefined
^

SyntaxError: Unexpected token u in JSON at position 0
    at JSON.parse (<anonymous>)
    at Object.<anonymous> (/Users/houmie/Projects/DynamoDBtoCSV/dynamoDBtoCSV.js:91:35)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47

Node.js v17.4.0