edawson / gfakluge

A C++ library and utilities for manipulating the Graphical Fragment Assembly format.
http://edawson.github.io/gfakluge/
MIT License
51 stars 20 forks source link

Pull in bug fixes #17

Closed edawson closed 6 years ago

edawson commented 6 years ago

Hey @LukasW94,

Thanks for the changes - looks like you've crushed some bugs! I'm going to review them and merge your changes in.

Cheers, Eric

LukasW94 commented 6 years ago

Small side note, I don't really think that the .gitignore should've been updated. This just made sure that, after being build, I didn't had to exclude any files/folders in my commit.

edawson commented 6 years ago

I think the .gitignore is a good update - we don't want machine-specific binaries in the repo, and we definitely don't want the tacky pre-build file flag in there as it's meant to signal we've built, not cloned.

I'm working on fixing the output now.