Closed adamnovak closed 6 years ago
@edawson Could you have a look at this, please? I'm wanting to use this fix in a PR to vg, and to use it it has to be merged in here.
This looks good. It has always been confusing that the walk_elem that Erik drew up used true for is_reversed and the path_elem of GFA1+ used essentially the opposite. I think you fix is fine - I'm merging.
It looks like path entry orientations are true for forward, and false for backward:
https://github.com/edawson/gfakluge/blob/1a78943536f36e0d08b4d2944ee4f0066fe610a8/src/gfakluge.hpp#L102
But when loading GFA files like this:
I get path_elem objects that look like this:
In other words, the
orientations
flags are backward when reading GFA 0.1 paths.