fillseq: segfaults when GFA does not exist, succeeds when FASTA does not exist

edawson / gfakluge

A C++ library and utilities for manipulating the Graphical Fragment Assembly format.

http://edawson.github.io/gfakluge/

MIT License

51 stars 20 forks source link

fillseq: segfaults when GFA does not exist, succeeds when FASTA does not exist #40

Closed sjackman closed 6 years ago

sjackman commented 6 years ago

gfak fillseq -f nonexistant.fa canu.unitigs.gfa >/dev/null; echo $?
Error: couldn't open fasta file nonexistant.fa
0

Expected behaviour: the exit status should be non-zero (1).

❯❯❯ gfak fillseq -f nonexistant.fa nonexistant.gfa >/dev/null; echo $?
Invalid input stream. Exiting.
Error: couldn't open fasta file nonexistant.fa
segmentation fault
139

edawson commented 6 years ago

This should now be fixed in e72833 .

sjackman commented 6 years ago

Thanks, Eric!