search

edawson / gfakluge

A C++ library and utilities for manipulating the Graphical Fragment Assembly format.
http://edawson.github.io/gfakluge/
MIT License
51 stars 20 forks source link

Remove std namespace pollution #57

Closed camillescott closed 4 years ago

camillescott commented 5 years ago

This is a followup to the pliib PR that removes std namespace pollution from the headers. I also took the liberty of making the Makefile conda compatible; this allows gfakluge to make use of conda-installed zlib, openmp, etc, and installs it into the conda environment, if one is activated.

ekg commented 5 years ago

Great work, thank you!

On Tue, Oct 22, 2019, 23:02 Camille Scott notifications@github.com wrote:

This is a followup to the pliib PR that removes std namespace pollution from the headers. I also took the liberty of making the Makefile conda compatible; this allows gfakluge to make use of conda-installed zlib, openmp, etc, and installs it into the conda environment, if one is activated.

You can view, comment on, or merge this pull request online at:

https://github.com/edawson/gfakluge/pull/57 Commit Summary

  • compile with -fPIC
  • Update gfakluge from edawson
  • extraneous git merge lines
  • Add CONDA_PREFIX to includes and lib
  • Remove the std namespace pollution
  • Make Makefile conda-compatible

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/edawson/gfakluge/pull/57?email_source=notifications&email_token=AABDQEOUREW7RXMDH4LRPFDQP5Z7ZA5CNFSM4JDYOBBKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTUOMDA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQELLSDOCO57N767ICV3QP5Z7ZANCNFSM4JDYOBBA .

edawson commented 4 years ago

Thanks y'all - merged!