search

edawson / gfakluge

A C++ library and utilities for manipulating the Graphical Fragment Assembly format.
http://edawson.github.io/gfakluge/
MIT License
51 stars 20 forks source link

gfak::mmap_open opens O_RDWR #65

Open tetron opened 4 years ago

tetron commented 4 years ago

gfak::mmap_open calls open with O_RDWR (read/write access). This fails with a cryptic error when the file is read-only:

odgi: /app/odgi/deps/gfakluge/src/gfakluge.hpp:569: size_t gfak::mmap_open(const string&, char*&, int&): Assertion `false' failed.
tetron commented 4 years ago

The workaround is to make the file writable (but this entails making a copy of the whole file in my case).

ekg commented 4 years ago

Yeah we should just patch this. It's not a problem.

On Tue, Apr 7, 2020 at 4:05 PM Peter Amstutz notifications@github.com wrote:

The workaround is to make the file writable (but this entails making a copy of the whole file in my case).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/edawson/gfakluge/issues/65#issuecomment-610406986, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQEJ6G6LFVUPEUZWRIJLRLMXLVANCNFSM4MDESFGA .