search

edbee / edbee-lib

QWidget based Text Editor Component for Qt. Multi-caret, Textmate grammar and highlighting support.
Other
75 stars 26 forks source link

Revise: fix QString::split(...) for older Qt Versions #113

Closed SlySven closed 4 years ago

SlySven commented 4 years ago

A use of the above in the test code fails to build on anything older than Qt 5.14 as the enum used is only present in that and newer versions. Previously the enum was a member of the QString class rather than the Qt namespace...

Signed-off-by: Stephen Lyons slysven@virginmedia.com

SlySven commented 4 years ago

For some reason the CI tests (that the Mudlet team inserted into the code base in 47f970ce6cc34d8f3cc3c82c6b459c06757852a9) on Linux run against Qt 5.6 (it seems) so are thus borked currently...

SlySven commented 4 years ago

@gamecreature What is the minimum Qt version that you intend (or would like) the edbee-lib library to compile with?

gamecreature commented 4 years ago

Thank you!! I don't have a special wish for what the minimum version is. I will adjust for Mudlet if required... (Though I don't have the time to test every version) The only requirement I have is that it will run on the latest Qt.. So If you've got issues with Mudlet please let me know, and we can add workarounds like the one above!

SlySven commented 4 years ago

I don't have a special wish for what the minimum version is.

Well, it might be worth coding to at lest consider the oldest current LTS version (currently that is QT 5.12.8 IIRC with an EOL 2020/12/05)... https://en.wikipedia.org/wiki/Qt_version_history#Qt_5 is probably worth bookmarking...

gamecreature commented 3 years ago

@SlySven I agree on this. I think LTS is a good lowest version to aim for. (Sorry for the late response).