search

edbeeching / 3d_control_deep_rl

Baselines and memory-based scenarios for the ViZDoom simulator
https://edbeeching.github.io/papers/3d_control_deep_rl
MIT License
33 stars 6 forks source link

No reset of the GRU state on episode termination? #3

Closed csherstan closed 5 years ago

csherstan commented 5 years ago

It doesn't look like you're resetting the GRU state when the done variable is True. Is that on purpose? I would think that might cause problems for the agent in the tasks which require memory.

edbeeching commented 5 years ago

Hi, thanks for raising this. You will see I mask the hidden state based on episode termination see https://github.com/edbeeching/3d_control_deep_rl/blob/master/3dcdrl/models.py#L66. So this is working as intended.