edbeeching / godot_rl_agents

An Open Source package that allows video game creators, AI researchers and hobbyists the opportunity to learn complex behaviors for their Non Player Characters or agents
MIT License
942 stars 69 forks source link

Update setup.cfg to fix sb3 not training after installing godot-rl #120

Closed Ivan-267 closed 1 year ago

Ivan-267 commented 1 year ago

Set sb3 to use the same version as in the last successful test: https://github.com/edbeeching/godot_rl_agents/actions/runs/5348644125/jobs/9698779703?pr=117 which is stable-baselines3-1.2.0

This should fix the issue (https://github.com/edbeeching/godot_rl_agents/issues/119) temporarily until potential support for sb3 2.0 gets added in the future.

The change hasn't been tested extensively, I only tried to install it on Windows using pip install and ran testing using gdrl and clean_rl_example.py, both of which worked. More testing is welcome.

edbeeching commented 1 year ago

Hey @Ivan-267 , does version 1.8.0 not work?

Ivan-267 commented 1 year ago

When trying to install 1.8.0 locally I got conflicts with the requirement for gym==0.26.2 and a message that gym==0.21 is needed instead.

I also checked the "Install dependencies" section of a test environment (https://github.com/edbeeching/godot_rl_agents/pull/120/checks)

Successfully installed ... stable-baselines3-1.2.0 ...

And also on one of my local anaconda environments 1.2.0 was previously installed (now 2.0 is getting installed, which has conflicts with action spaces). I assume that version 1.2.0 was getting automatically selected based on compatibility with the gym version.

Based on that, it's likely that setting sb3 to 1.2.0 shouldn't cause conflicts and would enable sb3 to work for new gdrl installations as before.