edbeeching / godot_rl_agents

An Open Source package that allows video game creators, AI researchers and hobbyists the opportunity to learn complex behaviors for their Non Player Characters or agents
MIT License
942 stars 69 forks source link

Update ADV_STABLE_BASELINES_3.md #136

Closed Ivan-267 closed 1 year ago

Ivan-267 commented 1 year ago

Updated the docs for the sb3 example. Removed the code snippet since the example file is already linked, it may be easier than keeping the code snippet updated with each change to the example.

Ivan-267 commented 1 year ago

LGTM apart for the .\ , is this a windows thing?

I'll check if it works without it, it might be needed in Windows Powershell (used with Anaconda) as it autocompletes for me that way (typing python then pressing tab). If it's not needed, I'll remove it, but if it is needed I'll have to think about a solution to address both cases. Does it work that way in Linux?

Edit: It seems to work fine without the addition, I'll remove it from the docs.

edbeeching commented 1 year ago

Ye in linux it would just be:

python stable_baselines3_example.py --env_path=path_to_executable --speedup=8
Ivan-267 commented 1 year ago

Ye in linux it would just be:

python stable_baselines3_example.py --env_path=path_to_executable --speedup=8

Thanks for noticing this, I made a quick check and it seems to be Windows Powershell specific, so it wouldn't work for other OS. However, it works without the extra ./ in Powershell as well. I updated the docs to resolve it.