search

edbeeching / godot_rl_agents

An Open Source package that allows video game creators, AI researchers and hobbyists the opportunity to learn complex behaviors for their Non Player Characters or agents
MIT License
942 stars 69 forks source link

RaycastSensor3D not working in godot 3.5 version #54

Closed visuallization closed 1 year ago

visuallization commented 1 year ago

Hey there,

Since _spawn_nodes() is commented in the _ready function in RaycastSensor3D .gd no rays are getting created which can hit the environment. Is there a reason why this commeted out? It makes RaycastSensor3D on the branch godot3.5 somewhat useless.

Kind Regards

grafik

edbeeching commented 1 year ago

Hi, the current version of the library supports 4.0 beta only.

In the current version of the plugin, this line is not commented out. Where did you copy the plugin from?

visuallization commented 1 year ago

Hey there,

Thanks for the answer! I got the plugin a few months ago (I think it was in October or November) from the main branch from this repo. It was at a time where the code still worked with godot 3.5. When copying the plugin from the branch godot3.5 the raycast sensor is still not working because of the commmented line. It seems to work fine however if I just uncomment the line. I just wanted to make sure I am not missing something and wanted to know why the line was commented out in the first place (maybe something is still broken and I am not aware of it)

Cheers

visuallization commented 1 year ago

Edit* I just remembered: I got the version from the release page. More specifically I got the version 0.2.2 from here https://github.com/edbeeching/godot_rl_agents/releases/tag/v0.2.2

Cheers Mate

yaelatletl commented 1 year ago

Let me look into it :D

yaelatletl commented 1 year ago

This has been fixed now in the godot 3.5 branch, ported 4.0 features of the addon to it

visuallization commented 1 year ago

@yaelatletl Thanks for looking into this. I checked out the changes and used it in godot3.5. However I experienced some problems so I fixed it and created a PR. Feel free to merge it if you guys agree with it.

https://github.com/edbeeching/godot_rl_agents/pull/56