plugin: fix(sync): prevent the plugin from crashing

edbeeching / godot_rl_agents

An Open Source package that allows video game creators, AI researchers and hobbyists the opportunity to learn complex behaviors for their Non Player Characters or agents

MIT License

942 stars 69 forks source link

plugin: fix(sync): prevent the plugin from crashing #56

Closed visuallization closed 1 year ago

visuallization commented 1 year ago

by initialize args as empty dict + use iterations_per_second instead

_get_speedup would throw an error in the editor as args would be null
use Engine.iterations_per_second instead of Engine.physics_ticks_per_second as physics_ticks_per_second would only work in godot 4 and throws an error in godot3.5

yaelatletl commented 1 year ago

Good catch!

visuallization commented 1 year ago

@yaelatletl should we create another release? if people get the code from release 0.2.2 https://github.com/edbeeching/godot_rl_agents/releases they have broken rayscast sensors.

yaelatletl commented 1 year ago

I'd say yes, but probably it's better to wait till 4.0 work gets fully backported, for the meantime I'll make an issue to track progress