search

edbeeching / godot_rl_agents_examples

Example Environments for the Godot RL Agents library
MIT License
37 stars 13 forks source link

feat(macos builds): added macos build support #2

Open visuallization opened 1 year ago

visuallization commented 1 year ago

Hey there,

I added mac os build support. I added the macos template into the repo export_templates/4.0.rc2/macos.zip (not sure if that's the best way because it is rather big) and also included the export_presets.cfg to make the builds work out of the box. I also updated the projects to make them build on mac without breaking compile errors. But the most relevant changes can be found in these commits:

Furthermore I updated the VirtualCamera example to make it compile & build in godot4 but there seem to be some game logic issues which still need to be tackled. I didn't manage to make the FPS example run in a timely manner as of the mentioned missing Skeleton3D modification support: https://github.com/godotengine/godot/pull/71137. I think this should be tackled in a separate issue.

I am not sure if the mac builds will compile on linux without problems because of code signing and xcode, so please let me know. If it does not work, there seems to be a way to build for mac on linux: https://docs.godotengine.org/en/latest/contributing/development/compiling/compiling_for_macos.html#cross-compiling-for-macos-from-linux

visuallization commented 1 year ago

@edbeeching Did you by chance had time to test this?

edbeeching commented 1 year ago

Hey, not yet. Hopefully tomorrow. Thanks for this.

edbeeching commented 1 year ago

Hi, I got around to trying this. Unfortunately, the mac build templates don't work on linux. I think we would have to include a build server as part of the CI workflow. Unless you have any other ideas?

visuallization commented 1 year ago

@edbeeching okay yeah I thought so. A build server is the only option I can also think of.