search

edbennett / glue_analysis

MIT License
0 stars 1 forks source link

Type annotations #3

Closed chillenzer closed 1 year ago

chillenzer commented 1 year ago

Any good reason for not using strict mypy mode?

edbennett commented 1 year ago

I'm somewhat dubious of adding type annotations before having some way to check their correctness (similar to having comments that can desync from the code); once we have a test suite that we can run mypy on then this would seem to make sense.

chillenzer commented 1 year ago

On that note: Wanna try ruff for that? I have read some good things about it recently but never tried it.

chillenzer commented 1 year ago

PS: Actually not sure, if it supports type checking by now but for the rest I mean...

edbennett commented 1 year ago

Sure, why not