search

edbennett / glue_analysis

MIT License
0 stars 1 forks source link

Introduce pre-commit #8

Closed chillenzer closed 1 year ago

chillenzer commented 1 year ago

I've taken the liberty of implementing (what looks to me like) a reasonable pre-commit setup.

One notable thing is that it bumped up the Python version to 3.11.* It is kind of established by now but we know how some researchers are with updating their software stack.

The rest is introduction of type annotations and formatting.

*This is because I wanted to have ANN rule set which wants to have self annotated which is only possible in 3.11 in a readable way.

chillenzer commented 1 year ago

PS: Just realised that in moving the member variables out of the __init__ function for CorrelatorEnsemble I have left them uninitialised. I didn't plan to change existing behavior. Is this something we want to have or not?