search

edbizarro / gitlab-ci-pipeline-php

:coffee: Docker images for test PHP applications with Gitlab CI (or any other CI platform!)
https://hub.docker.com/r/edbizarro/gitlab-ci-pipeline-php
MIT License
528 stars 166 forks source link

PHP 8.0 Support #112

Closed Pezhvak closed 3 years ago

Pezhvak commented 3 years ago

Note: I've removed xmlrpc for PHP 8.0 installations read here

Pezhvak commented 3 years ago

@edbizarro done

edbizarro commented 3 years ago

@edbizarro done

Thanks! I'll take a look

briandotdev commented 3 years ago

Darn I was also working a PR for this over the last two days 😂

Did you run the Goss test with no errors? AMQP extension in PECL is not yet PHP 8 compatible and in my testing was silently failing the entire PECL install routine for all other modules. The container build didn't catch the error.

Pezhvak commented 3 years ago

Darn I was also working a PR for this over the last two days 😂

Did you run the Goss test with no errors? AMQP extension in PECL is not yet PHP 8 compatible and in my testing was silently failing the entire PECL install routine for all other modules. The container build didn't catch the error.

please do check and test this PR and tell me if anything needs to be addressed. I'm already using built image from it in my CI/CD without any issue.

briandotdev commented 3 years ago

please do check and test this PR and tell me if anything needs to be addressed. I'm already using built image from it in my CI/CD without any issue.

Xdebug 2.9.0 is also not compatible with PHP 8. Requires Xdebug 3. That one was also silently failing. What's the output of your Goss test after build?

Pezhvak commented 3 years ago

please do check and test this PR and tell me if anything needs to be addressed. I'm already using built image from it in my CI/CD without any issue.

Xdebug 2.9.0 is also not compatible with PHP 8. Requires Xdebug 3. That one was also silently failing. What's the output of your Goss test after build?

i will check those and get back to you, can't do it today

briandotdev commented 3 years ago

I'm showing the following tests failing on image built from this PR. image

Pezhvak commented 3 years ago

@edbizarro it really means a lot for him, i close this PR in favor of #113.

edbizarro commented 3 years ago

c'mon guys