search

edbizarro / gitlab-ci-pipeline-php

:coffee: Docker images for test PHP applications with Gitlab CI (or any other CI platform!)
https://hub.docker.com/r/edbizarro/gitlab-ci-pipeline-php
MIT License
529 stars 167 forks source link

Enable xdebug coverage in alpine images #115

Closed jnoordsij closed 3 years ago

jnoordsij commented 3 years ago

The xdebug ini file to enable coverage is missing in the alpine images, as it was not added in the alpine/extensions.sh script. In the PHP 7.4-alpine image this still seemed to be working (I'm not sure how), but in the new 8.0-alpine image code coverage did not work.

Also I added a test to check images for this file. I haven't been able to test all existing images yet with the new tests, but they work on the 7.4, 8.0 and 8.0-alpine images.

jnoordsij commented 3 years ago

Note: there seems to be more recent additions in the extensions.sh file that are missing in the alpine/extensions.sh file, but I'm not quite sure which are needed and wether or not they can be copied blindly.

j3j5 commented 3 years ago

Adding into this, Debian images for PHP 7.2+ are installing XDebug3 but Alpine images are installing 2.9.2.

I'm all for moving to XDebug3 where possible, but whatever the choice, I guess we should be consistent.