search

edbizarro / gitlab-ci-pipeline-php

:coffee: Docker images for test PHP applications with Gitlab CI (or any other CI platform!)
https://hub.docker.com/r/edbizarro/gitlab-ci-pipeline-php
MIT License
528 stars 166 forks source link

Switch to mysql-client #118

Open Synchro opened 3 years ago

Synchro commented 3 years ago

Add MySQL's key and repo and use it to install mysql-client in place of mariadb-client, should fix #117.

I have no idea how to test this, but I've tested the individual commands.

edbizarro commented 3 years ago

Thanks @Synchro

Can you take a look on the alpine images as well? Thanks.

Synchro commented 3 years ago

That's not quite so easy. Alpine doesn't have a MySQL package, or rather it does, but it actually installs MariaDB. It seems that MySQL itself contains support for Alpine, but Alpine does not in turn provide a packaged version of it. There is an open request to add a real MySQL package to Alpine, but it's not getting much love, so I commented on it to try to push things along.

Synchro commented 3 years ago

Any chance of merging this? All projects on gitlab using Laravel 8 schema dumps will be breaking because of this issue. What's here won't fix Alpine, but it will at least fix Debian, which I expect is the majority.

CptOrange16 commented 2 years ago

This would be very useful for us, we recently updated our system to mysql 8 and it would be nice to be able to have the same version running ok for gitlab

Synchro commented 2 years ago

For anyone running into this, I solved this by simply switching to a different image, no other changes required, and it just works:

image: lorisleiva/laravel-docker:8.0