search

edbizarro / gitlab-ci-pipeline-php

:coffee: Docker images for test PHP applications with Gitlab CI (or any other CI platform!)
https://hub.docker.com/r/edbizarro/gitlab-ci-pipeline-php
MIT License
529 stars 167 forks source link

Support for PHP 7.2 #22

Closed edbizarro closed 6 years ago

johnhout commented 6 years ago

@edbizarro Any ETA on this?

edbizarro commented 6 years ago

@johnhout today! sry for delaying it

johnhout commented 6 years ago

@edbizarro NP Glad to see it show up :) Can I help you with anything?

RamonSmit commented 6 years ago

@edbizarro Did NPM change to v9 on purpose? We're having issues with our deployment stack at the moment. 

$ node -v
v9.4.0

Using docker image edbizarro/gitlab-ci-pipeline-php:7.1 ID=sha256:a7c4b4e6ac1a178d769b15d89fb57cd21b4c800057c7ffaf4b485a64444bdc6a for build container...

 Found bindings for the following environments:
          - Linux 64-bit with Node.js 8.x
edbizarro commented 6 years ago

hi @RamonSmit yes, the node package was updated to 9

What problem you're facing?

RamonSmit commented 6 years ago

@edbizarro Ah alright.

We just invalidated our CI caches. That solved the problem looks like.

We where facing this error:

ERROR in ../web/web.scss
    Module build failed: Error: Missing binding /builds/.../node_modules/node-sass/vendor/linux-x64-59/binding.node
    Node Sass could not find a binding for your current environment: Linux 64-bit with Node.js 9.x

    Found bindings for the following environments:
      - Linux 64-bit with Node.js 8.x

It was just a bit weird when the pipeline runs valid on a MR, and after the MR just breaks on every CI instance haha.