search

edbizarro / gitlab-ci-pipeline-php

:coffee: Docker images for test PHP applications with Gitlab CI (or any other CI platform!)
https://hub.docker.com/r/edbizarro/gitlab-ci-pipeline-php
MIT License
529 stars 167 forks source link

Revert to node 11 #60

Closed j3j5 closed 5 years ago

j3j5 commented 5 years ago

Hi, is there a way to revert the node version to 11? My builds are failing due to https://github.com/sass/node-sass/pull/2633, which is blocked and won't be merged till the people from node implement the NaN version.

Could you release a tag with node 11, at least till node-sass is fixed? Any other suggestions?

Thanks.

edbizarro commented 5 years ago

Sure!, node-saas package is very problematic indeed.

I'll keep an eye on that issue to update to node 12 only after they fix the problem.

In the meantime. the alpine images have a lts version, if you're using it, just append -lts in the image name until the build of v11 finished.

j3j5 commented 5 years ago

Thank you very much, unfortunately I'm not using alpine atm but, since you mention it I'm going to try if migrating the image for our builds isn't too problematic. I can't remember why we weren't using it in the first place but is worth a try.

Obrigado pelo seu ótimo trabalho.

edbizarro commented 5 years ago

All images (except lts) are changed back to Node v11

edbizarro commented 5 years ago

Version node-saas/v4.12.0 was released with support for node v12.

I'm going to close this issue and update all images to v12 again.

j3j5 commented 5 years ago

Great, thanks for the quick action!