search

edbizarro / gitlab-ci-pipeline-php

:coffee: Docker images for test PHP applications with Gitlab CI (or any other CI platform!)
https://hub.docker.com/r/edbizarro/gitlab-ci-pipeline-php
MIT License
529 stars 167 forks source link

Upgrade cassandra extension to be compatible with PHP 7.4 #83

Closed erickskrauch closed 4 years ago

erickskrauch commented 4 years ago

The extension doesn't work on alpine at the moment. It seems that among all the libraries the extension is built with it does not find PHP itself :)

The build for Debian is going well.

erickskrauch commented 4 years ago

Thanks to helping from @afdw, it was possible to fix the build on Alpine. To be honest, I still unable to figure out why the build was successful on Debian (and why it's still built with the patch), or why applying the patch doesn't break the compilation of older PHP versions, but in general it works.

We had to add the use of the patch https://github.com/datastax/php-driver/pull/135 (which fixes the changes in PHP's src https://github.com/php/php-src/pull/4394) because it's still not merged. I'll monitor this PR and as soon as it will be merged, I'll update the installation.

P.S. I also added a "full" binary installation for patch, because I need it to apply the patch + I need it to work with cweagans/composer-patches, which I use on one of my projects. In general, I think that it is good to have it in the base image.

erickskrauch commented 4 years ago

@edbizarro, can you merge this, please? :)