edc / bass

Make Bash utilities usable in Fish shell
MIT License
2.2k stars 70 forks source link

Shift $1 out prior to eval #100

Open zavorka opened 3 years ago

zavorka commented 3 years ago

Shift the first positional parameter out into a variable before running the eval command, so that it is not passed onto sourced scripts.

Fixes #89

edc commented 3 years ago

Sorry about the late response. Could you please add a quick test? Thanks!

skycaptain commented 2 years ago

@zavorka @edc anything we could to to push things forward?

JDuchniewicz commented 2 years ago

Is it possible to merge this any time forthcoming?

yoeluk commented 2 years ago

this seems left behind but it is still very frustrating behaviour... I think that the change requested by @edc is essentially this command = 'shift; eval $1 && ({}; alias) >&{}'.format(. If this is correct, can we satisfy this @zavorka ?