edc / bass

Make Bash utilities usable in Fish shell
MIT License
2.2k stars 70 forks source link

Add basic test. #20

Closed danhper closed 8 years ago

danhper commented 8 years ago

I added a short test (if we can call that a test), to allow Travis to check multiple Python versions. It should help avoiding regressions. https://travis-ci.org/tuvistavie/bass/builds/89736654

edc commented 8 years ago

Awesome!

One potentially dumb question about Travis: when we set the python version to, say, 3.5, does it then alias python to python3.5?

danhper commented 8 years ago

Travis uses virtualenv to manage Python versions, so I suppose it does something like this:

virtualenv -p /path/to/python3.5/bin/python /path/to/project
source /path/to/project/bin/activate

which does more or less something like this.

Edit: After looking at the build log, it seems that a virtualenv already exists per Python version, so the virtualenv -p step is probably already done, and when running the build, it only needs to source the desired version's virtualenv bin/activate script.

edc commented 8 years ago

Nice! Thanks for making this.

danhper commented 8 years ago

No problem! Don't forget to add the repository to Travis so that PR are checked automatically!