search

edc / bass

Make Bash utilities usable in Fish shell
MIT License
2.2k stars 70 forks source link

Dollar sign on command output interrupts execution #44

Closed Markcial closed 7 years ago

Markcial commented 7 years ago

From https://github.com/sdkman/sdkman-cli/issues/294#issuecomment-300814204

Replacing line 50 of __bass.py with the following content fixes this issue:

script_lines.append("printf %s;printf '\\n'" % json.dumps(line.replace('$', '\$')))

but i don't know if there is more implications

edc commented 7 years ago

@Markcial can you try doing it on line 71 just to be more conservative? If it works, would you mind sending a pull request?

Markcial commented 7 years ago

Sorry, been busy lately, let me do the PR so you can check it, thanks

edc commented 7 years ago

Fixed in #45 by @Markcial