search

edc / bass

Make Bash utilities usable in Fish shell
MIT License
2.2k stars 70 forks source link

Fix NixOS support #80

Closed evanrelf closed 4 years ago

evanrelf commented 4 years ago

This commit https://github.com/edc/bass/commit/4beb35458cfcccef080b9764c97f928e149dca49 changed rm to /bin/rm in order to avoid using a user-defined alias. It's better to use something like Fish's command builtin to ignore aliases, instead of assuming something is present at an absolute path.

NixOS is an operating system where /bin/rm is not available, so this fixes support on NixOS.

I also made the bass function try to use a more specific python executable such as python3 to avoid assuming the python executable is Python 3 and not Python 2.

edc commented 4 years ago

Thanks for the fix!