edcarp / python-intermediate-esces

ESCES Intermediate Course
https://edcarp.github.io/python-intermediate-esces/
Other
1 stars 3 forks source link

NaNs in strings? #16

Closed wood-chris closed 1 year ago

wood-chris commented 1 year ago

@bricheno does it make sense for empty string values to be NaN? Is this how the underlying data displays it or has it been munged somehow on the journey?

wood-chris commented 1 year ago

@bricheno e.g. 2 "site types" are NaN

wood-chris commented 1 year ago

Suggestion: Perhaps we should call all missing values in strings ‘unknown’?

wood-chris commented 1 year ago

@bricheno The affected record_ids are 3 and 10:

waves_df[waves_df['Site Type'].isna()]

is this on purpose or should they given a value?

wood-chris commented 1 year ago

Fixed when buoy_data csv was created