search

edcarroll / ng2-semantic-ui

Semantic UI Angular Integrations (no jQuery)
https://edcarroll.github.io/ng2-semantic-ui/
MIT License
615 stars 223 forks source link

Rename Project "ng-semantic-ui" #162

Open edcarroll opened 7 years ago

edcarroll commented 7 years ago

This one has been a long time coming, ever since Angular 2 became "just angular" and started asking people to avoid the ng2 prefix, hence ngx-semantic-ui.

I wanted to open it as an issue however to let anyone weigh in on the name change / suggest alternatives before I go through with it.

A potential alternative that has been raised is ng-semantic-ui, though with the major project ngSemantic my worry is they're too similar.

What do people think?

mcosta74 commented 7 years ago

According to this, acceptable names for 3rdparty lib could be:

Said that I've seen ng-semantic-ui, angular-semantic-ui and ngx-semantic-ui are already used in (www.npmjs.com).

I'd prefer to avoid the ngx- prefix; so if you think ng-semantic-ui (my favourite) could generate confusion, go for angular-

trevordaniels commented 7 years ago

I think ng- or angular-semantic-ui. Not too similar to ngSemantic for me.

danielritter commented 7 years ago

I would prefer angular-semantic-ui or angular-semanticui.

genuinefafa commented 7 years ago

angular-semantic-ui here!

rsnyman commented 7 years ago

My personal preference is for ngx- mostly just because this means it's Angular (as opposed to AngularJS), and because a lot of the older AngularJS projects used ng-. Having said that, I see that Angular now promotes angular- or ng-, so whatever my preference is, it sounds like you should rather go for one of those. Of course the other option (according to Angular) is Semantic UI for Angular but that's rather long-winded (and how do you name your package in npm then?).

sumitridhal commented 7 years ago

I prefer ngx-

edcarroll commented 6 years ago

Thank you everyone for your collective input. I've thought a lot about this, and I've decided to go with just plain ng-semantic-ui for a number of reasons.

The primary few are that:

  1. Avoiding the x is superior as it's a remnant of AngularJS, enough time has passed for people to see that Angular or ng means Angular 2+
  2. Shorter is better, which is why I went for ng- rather than angular-
  3. ng follows the official presskit guidelines

There are of course a few other factors but those were the main driving points behind the decision.

As an update to this, I'm now in the process of sorting out npm conflict resolution, and have emailed the owner of ng-semantic-ui to request the name. The name change depends on how long it takes for them to reply, (could be between a week or a month), so will keep you updated 😄

edcarroll commented 6 years ago

Movement! I now control both:

ng-semantic-ui and @ng-semantic-ui (the whole scope).

So: for the project rename, what are people's thoughts on the package name?

We could go for the plain old ng-semantic-ui, though this precludes the option of publishing different packages under the scope. Otherwise, going for @ng-semantic-ui means we need to pick a "sub name" - my current thoughts were just @ng-semantic-ui/lib.

I want to avoid the full @ng-semantic-ui/ng-semantic-ui as although it's done elsewhere (looking at you ng-bootstrap) I feel it isn't as good as a shorter name like lib or core.

edcarroll commented 6 years ago

P.S. Rename will be happening with the release of v0.10.0

rsnyman commented 6 years ago

I get why you want to use core or lib, but are you ever going to have more than 1 repository and more than 1 library?