search

edcarroll / ng2-semantic-ui

Semantic UI Angular Integrations (no jQuery)
https://edcarroll.github.io/ng2-semantic-ui/
MIT License
615 stars 224 forks source link

Update to Semantic UI 2.3 #349

Open ghost opened 6 years ago

ghost commented 6 years ago

Hi! Semantic UI 2.3 is out.

Can I count on you to update ng2-semantic-ui to this version?

There were some changes regarding modals positioning that need fixing after upgrade of Semantic UI. Probably there are some more, this is just what I've noticed.

I use your lib in a corporate tool and it's really nice to work with but such update would be greatly appreciated.

ghost commented 6 years ago

Well, a quick global css fix did it for me as long as all the modals have the same width but life shouldn't be like this ;D

.ui.modal
  left: calc(100% - $half_modal_width)

Still counting on you :)

Jeffen commented 6 years ago

calc(100% - $half_modal_width) does not work for me. My way is to import modal.css after semantic.css 2.3.0 in index.html like following:

<link href="https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.3.0/semantic.min.css" rel="stylesheet" defer>
  <link href="https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.2.13/components/modal.css" rel="stylesheet" defer>
ghost commented 6 years ago

This is indeed more reliable fix, although would be great if this was fixed properly.