Fix sui-search styling to allow fluid class to work - Githubissues

edcarroll / ng2-semantic-ui

Semantic UI Angular Integrations (no jQuery)

https://edcarroll.github.io/ng2-semantic-ui/

MIT License

615 stars 223 forks source link

Fix sui-search styling to allow fluid class to work #372

Open TroyMurphy opened 6 years ago

TroyMurphy commented 6 years ago

Seems super simple, but I'm not confident enough to know if changing the display affects other things.

Bug description:

sui-search fluid class does not work as bounding container is not expanding as it does in default semantic ui.

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/X6517cax71hip8z164Lc?p=preview

Version of Angular, ng2-semantic-ui, and Semantic UI:

Angular: 5.0.2 ng2-semantic-ui: 0.9.6 Semantic UI: 2.2.9

Suspected Fix:

https://github.com/edcarroll/ng2-semantic-ui/blob/master/src/modules/search/components/search.ts#LC45

change inline-block to block

edcarroll commented 6 years ago

Thank you for this, would you be able to open a PR and have a play with the demo to see if you can see any issues? Happy to then double check and we can merge the fix if all ok!