search

edcarroll / ng2-semantic-ui

Semantic UI Angular Integrations (no jQuery)
https://edcarroll.github.io/ng2-semantic-ui/
MIT License
615 stars 223 forks source link

Is this project dead? #431

Open Ralms opened 5 years ago

Ralms commented 5 years ago

I've decided go use Semantic UI on my Angular project because of this project. However after having several issues with it where things either straight up don't work (drop down menu in Input) or the documentation isn't clear enough (Modal), I've come back here but looking around I see no commits for over 6 months. There are pull requests to fix stuff waiting for more than 1 year... without a single acknowledge from the repository owners.

I'm really sad to see this like this, as I really hoped that this would be a good bootstrap replacement.

Version of Angular, ng2-semantic-ui, and Semantic UI:

Angular: 7.2

mikejf-pr commented 5 years ago

The maintenance state of this project is something that we're interested to find as well. I understand @edcarroll may well have other commitments, but if that's the case should expanding the owners to other trusted developers be discussed so forward movement can be kept up? It's a far preferable prospect than the chaos that would come with major project forks.

TonBits commented 5 years ago

Fork? Reboot this project? Who is in?

apijay commented 5 years ago

Fork? Reboot this project? Who is in?

At this point seems like fork is the only way

janpapenbrock commented 5 years ago

We, @hochzehn, are using this project actively and have patched some things in our own fork. We would contribute to a community-driven fork, if such emerged (maybe similar to how Fomantic-UI forked Semantic-UI).

h0raz commented 5 years ago

I don't have that much experience with community driven forks yet but I'd gladly help to get this repo active again since this seems the best angular semantic integration

I also looked into Fomantic-UI and it seems that it's getting more trackion every day Does it make sense to adapt the fork to Fomantic-UI instead of running on Semantic UI ?

mikejf-pr commented 5 years ago

I think at this point it's clear that @edcarroll isn't going to weigh in, unfortunately.

So, we'll have to organise a fork take over as a community-maintained package. Obviously we'd like to avoid splitting this into a bunch of different forked projects that never come together as everyone kicks off their own, so let's use this thread to have a discussion about where we should take this, who'd like to volunteer to administrate and contribute, so on. ('semantic-ui-ng'? We can finally get rid of that irritating 2. Sadly 'ng-semantic-ui' is taken. 'ngx-semantic-ui'? We're not meant to use ngx any more according to Google, but...)

With regards to Fomantic UI, Fomantic is largely aiming to be backwards compatible with semantic, so if we continue targeting this at semantic it should work with Fomantic. If we want we could have a sister project of fomantic-ui-ng with the fomantic componentry?

There are already existing forks which have been published, some of which contain FUI components, some of which contain bugfixes to SUI... we should bring in that code, coordinate with those maintainers if we can. Maybe they'd be willing to expand their projects to work as the new base, even.

edcarroll commented 5 years ago

I am sorry I haven't had the time to properly manage this project; life has become quite busy and so this has fallen by the wayside.

I am completely open to bringing on new maintainers - I just haven't had the time to look into this or properly choose someone. If someone is able to come forward, I would be happy to speak with them regarding the future of the project and them taking over as maintainer.

Regarding the name - I have control of ng-semantic-ui on npm. I was planning on renaming the project a while back - so this could be a fitting time to do that.

Let me know your thoughts.

Melmoth-the-Wanderer commented 5 years ago

Just wanted to mention that I have forked the project and updated the code to fit my needs (at work). We had to fix some issues when we used the combination of NgRx + ng2-semantic-ui (0.9.7) + AoT compiler. Repo is here, maybe someone will find it useful (or not). Changes are:

Additionally

If any of these changes are desirable I could make a PR to the original repo.

anna-bass commented 5 years ago

@Melmoth-the-Wanderer Sorry if this is off topic, but could you please explain a bit more in detail how you managed to fix https://github.com/edcarroll/ng2-semantic-ui/issues/432 in your forked project? I bumped into the same issue when trying to run "ng build --prod" for my Angular 8 app, and I don't quite understand exactly what fixed this issue in your case. Is it updating Angular to version 7, or is it some other change you mentioned? Would really appreciate your help, as the fact that it's not possible to build my Angular app with production flag is kind of a deal breaker.

Melmoth-the-Wanderer commented 5 years ago

@Melmoth-the-Wanderer Sorry if this is off topic, but could you please explain a bit more in detail how you managed to fix #432 in your forked project? I bumped into the same issue when trying to run "ng build --prod" for my Angular 8 app, and I don't quite understand exactly what fixed this issue in your case. Is it updating Angular to version 7, or is it some other change you mentioned? Would really appreciate your help, as the fact that it's not possible to build my Angular app with production flag is kind of a deal breaker.

@anna-bass, I'll be happy to help but I'm currently on vacation with no access to version control and source code. This is why I cannot give you simple solution right now. However, I believe that latest sources in this repository fixes this bug. This repo contains fixes that has not been released yet. Try to fork this repository and build it up using latest commit. This is what I did. After that I have pushed the package into my company's private repository. We're using Verdaccio - https://github.com/verdaccio/verdaccio.

I also had to manually fix some other errors in components/directives/templates of ng2-semantic-ui. But this is a different kettle of fish. Let me know if you managed to fix the problem with #432.

anna-bass commented 5 years ago

@Melmoth-the-Wanderer Thanks for letting me know that the fix for #432 has already been committed to this repo; I was not aware of it before. I managed to fix the problem by following your advice. If anyone struggles with the same issue, here are the steps that worked for me:

  1. forked this repository
  2. ran npm run lib:compile:prod to build a library
  3. used this library in my project instead of the "original" ng2-semantic-ui
  4. tried ng build --prod in my project
  5. bumped into #413, which I fixed with the solution provided in the comments

After that I tried ng build --prod again, and this time it went super smoothly! Thanks again for your input :)

mikejf-pr commented 5 years ago

If we look at the people who are actively contributing and updating their own branches since this one stopped on the network branch, we have individuals such as @TryHardDood (https://github.com/TryHardDood/ngx-fomantic-ui), @aplinet (https://github.com/aplinet/ng2-semantic-ui), @aligorji (https://github.com/aligorji/ng2-semantic-ui), @hochzehn (https://github.com/hochzehn/ng2-semantic-ui), @avohra (https://github.com/avohra/ng2-semantic-ui), @Melmoth-the-Wanderer (https://github.com/Melmoth-the-Wanderer/ng2-semantic-ui)

I'm calling the names out because ed did say he'd be open to bringing in more contributors or having someone take over as maintainer; or absent that, some or all could collaborate on a single forked project rather than multiple, which could take over as the new standard integration. It'd be great to have all of the various fixes and improvements brought together. (does github still notify people who are @-mentioned?)

Obviously it's not going to be a simple as just adding people - there's issue of code quality, choice of direction or changes, etc when there's multiple collaborators or maintainers, and some may not want to be part of the responsibility or group project - but I figured we should grab the people who are working on their own so we can talk and start figuring things out here.

Melmoth-the-Wanderer commented 5 years ago

My biggest concern is that https://github.com/Semantic-Org/Semantic-UI project is kinda dying, too. What is the purpose of investment in sinking ship? Over 800 issues opened and jlukic is kinda busy, too. Maybe jlukic and edcarroll are working together on something bigger now... ;-)

FYI: There is a FomanticUI project (https://fomantic-ui.com/) which is a community fork of SemanticUI. And I think that there is no "ng-fomantic-ui" repository to serve as fomantic-angular integration...

mikejf-pr commented 5 years ago

A great deal of that depends on if FomanticUI 3 is going to be a drop-in replement/extension for FomanticUI 2.x/SemanticUI 2.x. If so, then we can continue ongoing development of SemanticUI integrations with the knowledge that they'll work with FomanticUI, and even build features or components that are only useful when run against FUI.

If they're planning to make substantive breaking changes (which I very much hope they're not) then that introduces a whole community split that'd have to be managed.

nikita-fuchs commented 4 years ago

hey @anna-bass , would you be so kind to provide some info on how you managed to utilize the outputs of npm run lib:compile:prod as a library in an angular project ? If I copy the contents of the output in the dist folder into the dist folder of the ng2-sui module folder of my angular project, I'm getting errors :/

anna-bass commented 4 years ago

Hi @nikita-fuchs, I did not copy-paste the dist folder directly into my project. What I did was run npm pack in the dist folder of the forked ng2-semantic-ui to generate a .tgz file and then copy-paste that .tgz file into libs folder in my Angular project. After that I modified my Angular app's package.json to point to that local version of ng2-semantic-ui. As a result, I had the following in my package.json:

"ng2-semantic-ui": "./src/libs/ng2-semantic-ui-0.10.0-alpha.6.tgz"

Hope that helps.

andremartin commented 4 years ago

Hi @edcarroll et al Are there any news regarding potential new maintainer(s) for this project? I am seeing a bunch of new forks popping up each month that passes where folks are upgrading it to newer Angular versions while others patch and fix issues. It would be good to have a single repository that is maintained and where all these nice contributions can converge.

apijay commented 4 years ago

It would be great to see this project come alive again.