Closed btskinner closed 4 years ago
@wdoyle42: did you make some changes to the master
branch version of predict_grad.rmd
after I pushed my changes for the cross_validate
branch version? Can you accept the cross_validate
branch for merge first and then re-add your changes (or just reject my changes first)?
Rather than hit @wdoyle42 with a bunch of suggestions, I've made and pushed a number of changes. Here's an overview:
->
)$
to[["variable_name"]]
to allow future flexibility (can use columns names in a variable/object with second form, but not the first)r
folder tormd
since that seems more appropriatefigures
directory and have the one figure saved to that.gitignore
This works when running chunk by chunk, but I did have some problems at the very end when running
rmarkdown::render()
. Not sure what's going on.I'm assigning @wdoyle to review and make suggestions for me to fix. Once we've iterated, @ksalazar3 and @ozanj can review. But we can do it another way if others want.