eddelbuettel / bh

R package providing Boost Header files
85 stars 32 forks source link

Include bimap #24

Closed jimhester closed 8 years ago

jimhester commented 8 years ago

Previously only a subset of the bimap functionality was included, presumably because it was needed by other included components. Notably most of the bimap container adapters were absent, so you could not use anything but basic bimaps.

I basically downloaded boost_1_60_0.tar.gz and ran local/scripts/CreateBoost.sh with bimap added in boostextras and an updated date. If there is anything else needed please let me know.

eddelbuettel commented 8 years ago

I believe you. Can you edit the diff set to show just the relevant bit in the actual script(s) governing this? The resulting diff is too large be navigated efficiently (while I am traveling/in a rush).

jimhester commented 8 years ago

Here is the diff for just local/scripts/CreateBoost.sh

No rush on this so if it is not convenient to review now it can wait.

ommit 14d9b5a06c583d2c0863b93218cd3baed73a7b28
Author: Jim Hester <james.f.hester@gmail.com>
Date:   Sat Feb 20 14:26:43 2016 -0500

    Include bimap headers

diff --git a/local/scripts/CreateBoost.sh b/local/scripts/CreateBoost.sh
index 1172699..cd682d0 100755
--- a/local/scripts/CreateBoost.sh
+++ b/local/scripts/CreateBoost.sh
@@ -13,7 +13,7 @@ pkgdir="${HOME}/git/bh"
 boosttargz="boost_1_60_0.tar.gz"
 ## -- current package version and date (and other metadata as needed)
 version="1.60.0-0"
-date="2015-12-24"
+date="2016-2-20"

@@ -121,7 +121,7 @@ bcp --boost=${boostroot}  ${boostlibs}  ${pkgincl}   > /dev/null  2>&1
 # Plus phoenix (cf [github] issue ticket #19)
 boostextras="filesystem spirit foreach algorithm iostreams \
             dynamic_bitset heap any circular_buffer geometry fusion graph \
-            multiprcecision phoenix"
+            multiprcecision phoenix bimap"

 bcp --boost=${boostroot}  ${boostextras}   ${pkgincl}   > /dev/null   2>&1
eddelbuettel commented 8 years ago

Looks perfect. I'll trust you and just apply this.