search

eddelbuettel / bh

R package providing Boost Header files
85 stars 33 forks source link

Add property_tree to get json_parser.hpp? #29

Closed aydindemircioglu closed 7 years ago

aydindemircioglu commented 8 years ago

sorry, probably i'm just confused, but why is property_tree/json_parser.hpp not part of BH? is it a non-header-only? or is there any other reason?

(i'm definitely confused as my local update of RcppShark compiles well, but build_win cannot find the above file. )

eddelbuettel commented 8 years ago

Look at this section of the builder script: the explicitly selected Boost libraries and their dependencies are copied.

Boost property_tree is not yet part of this set.

I could look into adding it.

aydindemircioglu commented 8 years ago

i realized that in Shark sources json_parser is only used for creating a json file containing the version/build informations. this is not important for Rcppshark, so i removed the dependency.

for me the problem is solved for now, if you want to, you can close the issue. thanks again for bh and all the other work you do!

eddelbuettel commented 8 years ago

I am on the fence. It is probably small relative to the large size we already have, so I may keep this open.

eddelbuettel commented 7 years ago

Fixed in 1.62.0-1 which is now master and which should be in CRAN "within days".