search

eddelbuettel / bh

R package providing Boost Header files
85 stars 33 forks source link

Please add Boost sort to BH #35

Closed artemklevtsov closed 7 years ago

artemklevtsov commented 7 years ago

Hi. I can't found some boost headers in this package. Please tell me how can I use a missing headers in my package? Now I install the boost headers in my OS. But I look for a way to do it without external system wide dependencies.

eddelbuettel commented 7 years ago

See the DESCRIPTION of the package as well as the README of the repo; they both list a set of included Boost libraries in the BH.

Boost contains more libraries. We expanded BH over time -- see the NEWS.Rd (or ChangeLog or closed Issue tickets).

So to make it more concrete: what Boost library are you missing files from?

eddelbuettel commented 7 years ago

Is it this Boost sort library ?

artemklevtsov commented 7 years ago

Yes, it is sort library. spreadsort is too good to ignore it.

eddelbuettel commented 7 years ago

Ok. I'll retitle this ticket and take it as a request to add sort as it seems to be header-only and suitable.

How soon would you need it? What others have done, eg rstan, is to augment in their sources beyond what we have in BH now, and it to point to it in your sources via an extra -I....

By the next release (in a few months) it will be included in BH. Does that work for you?

artemklevtsov commented 7 years ago

Sure. For my own use cases I'll use the system wide headers.

eddelbuettel commented 7 years ago

If you want to ship to CRAN you could use the 'add missing files to packages sources' route.

artemklevtsov commented 7 years ago

Ok. Thank you for the suggestions and quick replies. My package now is pre alpha. So I'll wait the next BH release without any troubles.

eddelbuettel commented 7 years ago

All good. If you have a suggestion for where / how I could say more clearly that BH is a subset of Boost, don't hold back ;-)

eddelbuettel commented 7 years ago

This is now in master awaiting a release "real soon now" (but two other issues need to get sorted out first).