search

eddelbuettel / bh

R package providing Boost Header files
85 stars 33 forks source link

Support CUDA >= 9 #52

Closed cdeterman closed 6 years ago

cdeterman commented 6 years ago

Basically a copy of the pull request boostorg/config#175 to support the nvcc compiler for CUDA >= 9 when the version macros changed.

eddelbuettel commented 6 years ago

Will we find this in Boost 1.66 as well or is this a one-off patch? I couldn't quite see this in https://github.com/boostorg/config/pull/175.

cdeterman commented 6 years ago

I'm not sure if it will be in Boost 1.66 or not. I would imagine so although I don't know how to explicitly check other than asking boostorg. Are you then referring to seeing a reference to 1.66 in the pull request or that you don't see the changes reflected there?

cdeterman commented 6 years ago

@eddelbuettel I asked on the pull request thread and they confirm it is part of 1.65.1 and 1.66.0.

eddelbuettel commented 6 years ago

There are two possible situations:

  1. It is an upstream change, and it will always be present going forward.
  2. It is a one-off we would have to apply at each new release.

Any idea which we are facing? Isn;t the 1.66 release on GitHub too so you could locate the file?

ax3l commented 6 years ago

It's case 1. We applied this to the 1.66.0 release of boost (and current HEAD) and successfully got it backported it to the 1.65.1 boost release.

eddelbuettel commented 6 years ago

That however also means that we may not need the PR if we just go to 1.66.

cdeterman commented 6 years ago

That is fine, do you have a rough timeline for 1.66?

eddelbuettel commented 6 years ago

I try to balance not letting too much time pass, and also not overwhelm CRAN. Looks like the last one was in August so some time now probably, as I find time.

Do you need it deployed somewhere, ie do you need a CRAN version? We could indeed "patch" the most recent BH release with the PR and just put it onto a drat repo if that helps.

cdeterman commented 6 years ago

If you intend a release in the 'near' future that is fine. I have my local 'patched' copy that I can use for development in the mean time. This isn't a critical time frame as it is for extending one of my packages. Just so I know what to say to users who are interested in the future release. Whenever is convenient for you works for me. Thanks. We can likely close this request then.

eddelbuettel commented 6 years ago

Sounds good. Maybe I'll just leave it open just like an issue ticket reminder to do the next release.

eddelbuettel commented 6 years ago

@cdeterman I have a release candidate in this branch which should address

Can you give it a spin, and report back?

eddelbuettel commented 6 years ago

@cdeterman And the branch is soon going to be in master.

eddelbuettel commented 6 years ago

Bump. @cdeterman, are you around to test this? Else I'll just release as it looks ready from over here.

cdeterman commented 6 years ago

@eddelbuettel sorry, yes, I just completed my test. It is all good from my end.

eddelbuettel commented 6 years ago

Great. And thanks again for the nudge regarding Boost compute which looks spiffy. I'll toss this at CRAN then; should hopefully be out in a day or two.

And with that I close the PR as this is subsumed in BH 1.66.0 which we now have in master.