search

eddelbuettel / bh

R package providing Boost Header files
85 stars 33 forks source link

Backporting deprecation warning fix for integer_log2.hpp ? #64

Closed octomike closed 4 years ago

octomike commented 4 years ago

Hi!

I realize you are reluctant to modify boost source / backporting things for stability reasons, but I still wonder if it's possible to backport this single line fix to silence compile warnings like this:

In file included from /usr/lib/R/site-library/BH/include/boost/random/detail/integer_log2.hpp:19:0,
                 from /usr/lib/R/site-library/BH/include/boost/random/detail/large_arithmetic.hpp:19,
                 from /usr/lib/R/site-library/BH/include/boost/random/detail/const_mod.hpp:23,
                 from /usr/lib/R/site-library/BH/include/boost/random/linear_congruential.hpp:30,
                 from /usr/lib/R/site-library/BH/include/boost/random/additive_combine.hpp:27,
                 from /usr/lib/R/site-library/rstan/include/rstan/stan_fit.hpp:15,
                 from /usr/lib/R/site-library/rstan/include/rstan/rstaninc.hpp:3,
                 from stan_files/ctsmgen.hpp:18,
                 from stan_files/ctsmgen.cc:3:
/usr/lib/R/site-library/BH/include/boost/pending/integer_log2.hpp:7:89: note: #pragma message: This header is deprecated. Use <boost/integer/integer_log2.hpp> instead.
eddelbuettel commented 4 years ago

It should get taken care of when I move to Boost 1.71 (or maybe 1.72 will just be out by then).

octomike commented 4 years ago

Alright :+1:

eddelbuettel commented 4 years ago

I am with you though that it is annoying, as is CRAN's insistence to not allow compiler warning suppression (but yes, there is of course a defensible reason behind it) yet .... the line noise is a pain.

octomike commented 4 years ago

I completely understand, just wanted to double check your take on this :)