search

eddelbuettel / bh

R package providing Boost Header files
85 stars 32 forks source link

fix typo in cardinal_cubic_b_spline #71

Closed SymbolixAU closed 4 years ago

SymbolixAU commented 4 years ago

As per this commit in boost / math, there was a typo in the Cardinal Cubic B Spline header guard.

eddelbuettel commented 4 years ago

Thanks!

Out of curiousity, how did you notice? Where you bitten by this and you followed up to the Boost repo?

SymbolixAU commented 4 years ago

yes exactly that - here in colourvalues I use it.

eddelbuettel commented 4 years ago

So I presume you'd vote for making a -4 release and pushing to CRAN?

SymbolixAU commented 4 years ago

yes I would. Will it be possible to get it up in a day or so? (I'm crashing towards a 20th Mar deadline to get a few packages updated to handle R 4's stringsAsFactors before they're taken off)

If not my plan is to install the BH headers locally to colourvalues, then re-link when everything's up and running again.

eddelbuettel commented 4 years ago

I doubt it. Rcpp has been with them for days. Even if I forgo the rev.dep tests...

Can you reorder / prefix includes to get just that file from a local-to-your-package source?

BH is YUGE. You really don't want to embed it.

eddelbuettel commented 4 years ago

Ie in your line 11 you showed me above, do not include the (busted) file but a local copy. Still LinkingTo: bh and you get all its requirements.

Done in three minutes and no waiting for me or CRAN. Better?

SymbolixAU commented 4 years ago

I'll give it a go.