search

eddelbuettel / bh

R package providing Boost Header files
84 stars 33 forks source link

include license file #73

Closed beckermr closed 4 years ago

beckermr commented 4 years ago

According to the BSL-1.0, a license file needs to be shipped with the software but no such file appears in this repo. Can you please add one?

eddelbuettel commented 4 years ago

Done.

Can you 'hot-fix' your tarball by adding it? I probably won't cut a new release for CRAN just to add this.

beckermr commented 4 years ago

We are shipping a new release for R 4 and so will add it now. The old tarballs cannot be hot fixed.

beckermr commented 4 years ago

also, thank you!

eddelbuettel commented 4 years ago

Yes, sure, poor wording on my part. I didn't mean "let's rewrite history and alter published tarballs".

I meant alter your setup to (for now) use a local copy and trust me that this, as it is now committed, will be present going forward. In the Debian lingo I have worked with for 25 years, this would be part of the local diff just like your packaging meta info. But hey, you got it even though I explained like crap ;-)

Thanks for the pointer.

beckermr commented 4 years ago

Ahhhhhhh! Yup! We added the license file to the conda package itself and can remove that once it appears in the source. Thank you!