search

eddelbuettel / bh

R package providing Boost Header files
84 stars 33 forks source link

A request to add timer/include/boost/progress.hpp #84

Closed wush978 closed 9 months ago

wush978 commented 1 year ago

Hi Dirk,

I noticed a warning message related to progress.hpp recently:

/usr/local/lib/R/site-library/BH/include/boost/progress.hpp:23:1: warning: This header is deprecated. Use the facilities in <boost/timer/timer.hpp> or <boost/timer/progress_display.hpp> instead. [-W#pragma-messages]

As discussed in https://github.com/boostorg/timer/issues/12 , there is a file timer/include/boost/progress.hpp now and it is a replacement of boost/pgoress.hpp.

However, the BH package does not contain the file timer/include/boost/progress.hpp.

Could you add this file to BH, so we could migrate the class and prevent the warning message?

Best, Wush

eddelbuettel commented 1 year ago

Hi Wush,

Because Boost (and BH) are so big I tend to update only yearly in December. So chances we may get this with the next official version which should be bh 1.81 based ob Boost 1.81 due December. Would that be good enough? It is not really under my control whether the Boost folks include this or not.

Now the issue https://github.com/boostorg/timer/issues/12 you list is from a few years ago and references Boost 1.72 but then links to a commit tagged 1.80. So it depends on whether Boost gets this out with 1.81.

Hope this helps, Dirk

wush978 commented 1 year ago

That looks good to me. Thanks for your prompt reply!

eddelbuettel commented 1 year ago

PR #87, currently still open, has Boost 1.81.0 released yesterday.

eddelbuettel commented 1 year ago

The reverse dependency checks revealed some issues with a handful of packages so i will open an issue and contact the maintainers of those packages.

wush978 commented 1 year ago

Thanks for your follow-up. Please let me know if there is anything that I can help with.

eddelbuettel commented 1 year ago

Thanks -- we have to wait a little to sort a small amount of changes out -- see #88 which also has pointers to the not-yet-for-CRAN release 1.81.0-0.

eddelbuettel commented 1 year ago

And BH 1.81.0-1 is now on CRAN so you have the progress header at long last!

wush978 commented 1 year ago

Thank you!

wush978 commented 1 year ago

Hi Dirk,

Thanks for your work, but there might be a mistake. The progress_display.hpp in https://github.com/boostorg/timer/tree/develop/include/boost/timer is still missing in the latest BH: https://github.com/eddelbuettel/bh/tree/master/inst/include/boost/timer.

Should I re-open this issue again?

eddelbuettel commented 1 year ago

:cry:

Yes please.

Maybe I hand-copied it? The timer library seems to contain source code and so I may not have added it to the explicit bcp call, and I probably should. Sorry about that.

eddelbuettel commented 9 months ago

This is now (finally !!) in BH 1.84.0. There are very minor repurcussions with five packages (including yours which of course still throws the NOTE I prevented you from updating) so this will only be on CRAN in January after which time you can update yours. Until then you can get it from here, or from the r-universe builds and I may add it to the ghrr drat as well so that you can test your change.

Or, come to think about it, you could even test the change and maybe #if define a solution that works before and after?