eddelbuettel / bh

R package providing Boost Header files
85 stars 33 forks source link

BH 1.81.0 upgrade plan #88

Closed eddelbuettel closed 1 year ago

eddelbuettel commented 1 year ago

Boost released 1.81.0 this week, and the BH package was updated to release 1.81.0-0 in PR #87. It can be accessed from the ghrr drat via

install.packages("BH", repos=c("https://ghrr.github.io/drat", "https://cloud.r-project.org"))

and similarly from r-universe. As usual we ran full reverse-dependency checks on Debian testing system (where gcc-12 is the default). The logs are in this commit at the rcpp-logs repo are reveal issues in these six packages

I have or will contact all maintainers by either email or PR. The plan would be to get all packages fixed in four weeks from now to permit a mid-January CRAN upload of BH 1.81.0.

Edit 2022-12-30 We now have 1.81.0-1 (via #90) which had another round of reverse-depends checks which revealed no new or changed issue.

nx10 commented 1 year ago

I just submitted httpgd 1.3.1 which should resolve this issue (for httpgd): http://nx10.github.io/cransubs/pkg#httpgd

If anyone is interested in the fix, boost::beast string views switched internally from boost::detail::basic_string_view to boost::core::basic_string_view in the latest version. Of these the current one does not have a .to_string() method.

Edit: It was rejected in pretest due to (I believe) (https://github.com/eddelbuettel/bh/issues/89). I have informed CRAN.

eddelbuettel commented 1 year ago

Thank you so much, also for the added color. I have seen boost::core::* pop up in the context of the 'grand ole sprintf replacement' as there is a (pending/coming) boost::core::snprintf that I aded in 1.81.0-1 in order to minimize that issue.

(And good luck with CRAN. I always found them reasonable when I replied on such false positives. And an updated BH will be coming if all goes well by mid-Jan. Speaking of which, any update from the stan world @bgoodri ?)

bgoodri commented 1 year ago

I have a real fix. Just testing the reverse dependencies.

eddelbuettel commented 1 year ago

I would like to upload BH in the next few days. Of the six packages, only one (rlas) made it through. Uploading may help another (httpgd). I hope it may help rstan, colorvalues, TDA.

Thoughts?

bgoodri commented 1 year ago

I uploaded rstan to CRAN. It should be fine, but won't be approved until tomorrow at the earliest.

eddelbuettel commented 1 year ago

Cool, thanks for the update! I will try to follow-up with BH and we can continue to coordinate here.

Edit: With rstan now on CRAN I will likely follow suit very shortly.

nx10 commented 1 year ago

Seems like BH 1.81 is now on CRAN. httpgd will follow up shortly

eddelbuettel commented 1 year ago

Correct. It is now up on CRAN, I mentioned this issue, the two closed one and your 'pending' httpgd as open but imminently addressable and so it was moved ahead by the CRAN maintainers after a few days.

I will close this issue as completed, we can still discuss here needed.

Big big thanks to everybody for the prompt help.

eddelbuettel commented 1 year ago

@nx10: Yay!

image

Glad to see it back!

nx10 commented 1 year ago

Thanks! They requested a couple documentation changes so it got delayed again. 2.0 soon™