search

eddelbuettel / digest

R package to create compact hash digests of R objects
https://eddelbuettel.github.io/digest
111 stars 47 forks source link

Use endian macros to set endianness #191

Closed barracuda156 closed 1 year ago

barracuda156 commented 1 year ago

@eddelbuettel Could you please see if this works for you?

These macros should be supported both by GCC and Clang. And if undefined, should use default 0.

eddelbuettel commented 1 year ago

My general preference is to continue a discussion in an issue ticket until a consensus, and only then start PRs. Oh well.

Now, per https://sourceforge.net/p/predef/wiki/Endianness/ this should work. I cannot test this because you full well know I do not have big endian metal at my disposal. Apart from that, yes it "may work".

barracuda156 commented 1 year ago

(Rebased just to add that it closes the respective issue.)

eddelbuettel commented 1 year ago

I made two commits for the related M1 issue this morning. It would nice if you could rebase (or else I can squash-merge) and I always appreciate a ChangeLog entry (format is two spaces between names, date, email fields). Can you add that?

barracuda156 commented 1 year ago

Yes, sure, will do today.

eddelbuettel commented 1 year ago

Ping re https://github.com/eddelbuettel/digest/pull/191#issuecomment-1609317986

barracuda156 commented 1 year ago

@eddelbuettel Thank you!

P. S. Sorry for not being fast enough with rebase.