search

eddelbuettel / pinp

Pinp Is Not PNAS -- Two-Column PDF Template
147 stars 25 forks source link

support 'headercolor' and 'linkcolor' from frontmatter #39

Closed eddelbuettel closed 6 years ago

coatless commented 6 years ago

Anyway we could pass the values into the pinp.cls file like the footer defines?

eddelbuettel commented 6 years ago

We could. But is it really worth it? By now pinp.cls is "ours" anyway and not fully self-contained.

eddelbuettel commented 6 years ago

Well maybe we should :) I just tried two more "cleanups" just by renaming and dug myself a little hole. So reverted.

eddelbuettel commented 6 years ago

Suggest to just squash merge this and move on. We had this (trivial) issue open for a while.

There is one issue that would in fact merit a release: the improved end matter. I rendered a few package vignettes since 0.0.2, and things are better now. Maybe that should go out into the world?

coatless commented 6 years ago

I'll revisit later this week to hopefully change where the declarations are.

cc #33

eddelbuettel commented 6 years ago

I keep thinking that a test suite would be good. But comparing rendered pdf files (as a formal test) is not trivial / will be fragile. People tried that with charts too.

coatless commented 6 years ago

@eddelbuettel see what the RStudio folks do over at:

https://github.com/rstudio/rticles/blob/master/tests/testthat/test_formats.R

coatless commented 6 years ago

Let's talk about this in #40

eddelbuettel commented 6 years ago

Yes, completion to a file is good enough. We can do that in tests/someSimpleScript.R as well -- no need for extra dependencies.