search

eddelbuettel / pinp

Pinp Is Not PNAS -- Two-Column PDF Template
147 stars 25 forks source link

Feature/updated pnas (closes #77 #78) #79

Closed eddelbuettel closed 5 years ago

eddelbuettel commented 5 years ago

This looks ready. I tested it with most of the Rcpp vignette. The gnarly typesetting at the end is different now -- reference just become normal content of a column and 'flow'. I like that.

Some things appear to have changed, and have annoyed me for a while via persistent bickering from LaTeX itself over lack of options are a letter (or papersize) and now also printwatermark. So I removed mentions of them from the template.tex, skeleton.Rmd and the pair of R and Rmd. If you want watermarks back we have to start from the top and support it as an option to document type. It's just not that important to me. (One can still, it seems, toggle by flipping the value in the line
\setboolean{displaywatermark}{false} % Set to true to show the watermark -- pinp change
back to true. Good enough for me.

Let me know what you think.

coatless commented 5 years ago

LGTM overall. Only one nit on the aesthetic change w.r.t Acknowledgements.

eddelbuettel commented 5 years ago

Do you want to follow up with one commit (in the branch / pr) to finalize?

coatless commented 5 years ago

Thanks for making the changes. Just got back to the office after dropping my bike off for repair.

eddelbuettel commented 5 years ago

Ick. Broken bike sucks. Last time mine needed care it was gone for a week :-/

coatless commented 5 years ago

Downside of pinp is autocorrection to ping.