search

eddelbuettel / pinp

Pinp Is Not PNAS -- Two-Column PDF Template
147 stars 25 forks source link

Possible regressions in 0.0.8 #80

Closed eddelbuettel closed 5 years ago

eddelbuettel commented 5 years ago

The blog post describes some of the reasons why we needed to rush 0.0.8 out -- in essence, pinp was breaking CRAN check because something was afoul with the newest texlive.

I think we have a handle on this, but in upgrading we may have trampled on earlier pull requests and extensions. I am fairly certain that

In better news we no longer need the skip_final_break stuff @coatless and I did earlier.

For that I apologize. It is my fault as I should have kept the diffs more cleanly in order to reapply them on upgrades -- such as this one. I am fairly confident we can get this back and I will try harder to have a better process. I already added a copy of the current PNAS files so going forward we can diff changes between them.

eddelbuettel commented 5 years ago

Took a peek at papersize and that actually looks mostly good. I just removed the "else" case if injecting letter as fallback which now tickles a latex warning about unsupported option. Have a ranch on my laptop I can ship this evening.

@saghir if could test that in the next few days for suitability with a4 paper it would be much appreciated.

Edit: Tested what I have in a branch (that is close to master) on the train home and a4 and letter work. So papersize is good. As is date_subtitle which was not affected.

eddelbuettel commented 5 years ago

So ... looks like we are in pretty decent shape, and 0.0.9 will go out shortly.

pinp is working well is my use cases, and papersize, watermark, date_subtitle, ... all work.