search

eddelbuettel / pinp

Pinp Is Not PNAS -- Two-Column PDF Template
147 stars 25 forks source link

implemented document_date field #85

Closed ikashnitsky closed 4 years ago

ikashnitsky commented 4 years ago

Started from scratch in response to the recent discussion in #63

Discussion part Maybe there should be a bit more consistency between date_subtitle and document_date. In my view their behaviour can be a bit confusing since both default to \today. I'd suggest to rename date_subtitle into subtitle or infoline – just drop date from default in this line. The date of the document can stay only in the footer – freely specified as text with the new document_date YAML param or resolving to \today by default. What do you think?

ikashnitsky commented 4 years ago

For now I resorted to deleting the repo and forking it again ¯\_(ツ)_/¯

eddelbuettel commented 4 years ago

I just had a very first quick glance at it and it looks good. One minor suggestion for the manual page which I type up later. For an example run, any odd document plus an explicit YAML header argument document_date and maybe date_subtitle ?

(As for changing names of existing options: not great. Published "APIs" for users and all that....)

eddelbuettel commented 4 years ago

I will take silence from @coatless as absence of concerns and merge this :) Thanks for the new feature, being able to set both optionally is nice.

coatless commented 4 years ago

@eddelbuettel sorry, saw the earlier PR that was closed out. Missed this. That said, this looks good! Thanks @ikashnitsky!