search

eddelbuettel / rcppsimdjson

Rcpp Bindings for the 'simdjson' Header Library
116 stars 13 forks source link

unlink woes #33

Closed knapply closed 4 years ago

knapply commented 4 years ago

https://twitter.com/michael_chirico/status/1280675491448410113

"just poking around so I may be wrong, but it looks like that unlink should be diagnosis$input[[i]]?"

image

Once upon a time it was only URLs or only files. and unlink() would only affect downloaded files. That's no longer the case.

eddelbuettel commented 4 years ago

That was too short-hand for me. Maybe copy the tweet text time.

Bugs happen. I created millions in my day. Life goes on. Reasons for 0.1.1 :)

eddelbuettel commented 4 years ago

Thanks for the edit. I got there eventually. (It doesn't help that Chrome+Twitter, the combo of adblockers I have, don't directly send me to the tweet (high wtf factor here) so I always have to go a send time in incognito mode. Ahh the 1st world problems we have. Now you have know why I whine about directly quoting ;-)

BTW looks like you pushed on "empty" ie "unchanged" branch in issue/33. On purpose?

knapply commented 4 years ago

Yes, it was intentional.

eddelbuettel commented 4 years ago

Gotta love a good baseline to compare to :)

eddelbuettel commented 4 years ago

Done in #34