search

eddelbuettel / rcppsimdjson

Rcpp Bindings for the 'simdjson' Header Library
115 stars 13 forks source link

update to simdjson 0.5.0 #49

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

Better late than never :)

@knapply lemme know what you think. This isn't urgent as I have been, ahem, sitting on this for a few weeks but (coughs twice) beginning of term, this, that, the other and general "it's friggin 2020" madness appear to have gotten in the way :)

eddelbuettel commented 3 years ago

I'm not seeing any commented-out tests.

Yes, I followed up on this today with a PR that just turned them from expect_error() to expect_identical() with the results they now give -- see https://github.com/eddelbuettel/rcppsimdjson/pull/49/commits/5330193ec0664ae0a69dfba439f1029759f7e786 for details if curious.